dongjoon-hyun commented on code in PR #57759:
URL: https://github.com/apache/spark/pull/57759#discussion_r3714444418
##########
sql/api/src/main/scala/org/apache/spark/sql/Column.scala:
##########
@@ -30,11 +30,17 @@ import org.apache.spark.sql.internal.{ColumnNode,
TableValuedFunctionArgument}
import org.apache.spark.sql.types._
import org.apache.spark.util.ArrayImplicits._
-private[spark] object Column {
+/**
+ * The companion object is public so that extension developers can reference
the `Column` type as
+ * a value, which is what makes the `Column(expression)` factory provided by
+ * `org.apache.spark.sql.classic.ClassicConversions.ColumnConstructorExt`
usable outside of the
+ * `org.apache.spark` package. All of its members intentionally stay internal.
+ */
+object Column {
Review Comment:
If we change the visibility, we need annotations like we did for `class
Column`.
https://github.com/apache/spark/blob/496d20f8c05fa93407edefb123134026e259b9fe/sql/api/src/main/scala/org/apache/spark/sql/Column.scala#L139-L140
In this case, which one do you propose in this PR? `Stable` or
`DeveloperApi`, @peter-toth ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
