peter-toth commented on code in PR #57759:
URL: https://github.com/apache/spark/pull/57759#discussion_r3714590115
##########
sql/api/src/main/scala/org/apache/spark/sql/Column.scala:
##########
@@ -30,11 +30,17 @@ import org.apache.spark.sql.internal.{ColumnNode,
TableValuedFunctionArgument}
import org.apache.spark.sql.types._
import org.apache.spark.util.ArrayImplicits._
-private[spark] object Column {
+/**
+ * The companion object is public so that extension developers can reference
the `Column` type as
+ * a value, which is what makes the `Column(expression)` factory provided by
+ * `org.apache.spark.sql.classic.ClassicConversions.ColumnConstructorExt`
usable outside of the
Review Comment:
Agreed, that was a mistake on my side — `Column.scala` is in `sql/api`,
which Connect shares, so pointing at a classic-only API from there is wrong.
Dropped the `ClassicConversions.ColumnConstructorExt` reference in f4b2d232a86;
the doc now just says an implementation can add the factory via an extension
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
