dtenedor commented on code in PR #57691: URL: https://github.com/apache/spark/pull/57691#discussion_r3715984728
########## python/pyspark/sql/tests/df_golden/group_by.test: ########## @@ -1,40 +1,19 @@ --! name __file_metadata__ --! source -df_golden/group_by +pyspark.sql.tests.df_golden.test_group_by.GroupByGoldenTests Review Comment: Yes, currently there are a lot of these `.out` golden files for testing in Apache Spark (example [1]). We could consider changing that, but it would be a bigger change than this PR would do in one go. [1] https://github.com/apache/spark/blob/35395613033ed46df2b0ad67efbddd17188fc532/sql/core/src/test/resources/sql-tests/analyzer-results/kllquantiles.sql.out#L4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
