dtenedor commented on code in PR #57691:
URL: https://github.com/apache/spark/pull/57691#discussion_r3716265440
##########
python/pyspark/sql/tests/df_golden/df_golden.py:
##########
@@ -540,39 +603,36 @@ def hash_result_rows(rows):
# ---------------------------------------------------------------------------
-def run_script(spark, script_path):
- """
- Execute the test case script and return the DataFrame it assigns to ``df``.
+def _build_dataframe(spark, build_df):
Review Comment:
Sounds good, this is done.
##########
python/pyspark/sql/tests/df_golden/df_golden.py:
##########
@@ -744,3 +752,230 @@ def _compare_case(test_case, case, actual):
got.strip("\n"),
"[{}] mismatch in `{}`".format(name, key),
)
+
+
+def is_generating_golden():
+ """Whether this run regenerates the golden files instead of checking
them."""
+ return os.environ.get("SPARK_GENERATE_GOLDEN_FILES") is not None
+
+
+def check_cases_in_sync(test_file, declared, golden):
Review Comment:
This is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
