uros-b commented on code in PR #57842:
URL: https://github.com/apache/spark/pull/57842#discussion_r3735188659


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3610,6 +3597,30 @@ object SQLConf {
       .checkValue(v => Set(1, 2).contains(v), "Valid versions are 1 and 2")
       .createWithDefault(1)
 
+  val STREAMING_COMMIT_LOG_FORMAT_VERSION =
+    buildConf("spark.sql.streaming.commitLog.formatVersion")
+      .internal()
+      .doc("The version of the commit log format. The default value is 1. Will 
use the max of " +
+        "this and STATE_STORE_CHECKPOINT_FORMAT_VERSION as the commit log 
version, since a " +
+        "state store checkpoint format above 1 writes state store checkpoint 
ids that only a " +
+        "commit log at version 2 or above can persist.")
+      .version("4.3.0")
+      .intConf
+      .checkValue(v => Set(1, 2, 3).contains(v), "Valid versions are 1, 2 and 
3")
+      .createWithDefault(1)
+

Review Comment:
   Please make sure to add `withBindingPolicy` to both new confs @jerrypeng 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to