jerrypeng commented on code in PR #57842:
URL: https://github.com/apache/spark/pull/57842#discussion_r3751879013
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/CommitLog.scala:
##########
@@ -76,7 +70,12 @@ class CommitLog(
/**
* Factory for creating a [[CommitMetadataBase]] for the requested wire
format version.
- * Defaults to the version configured via
[[SQLConf.STATE_STORE_CHECKPOINT_FORMAT_VERSION]].
+ *
+ * The version is a parameter rather than a field read from the session
config, so that a caller
+ * always supplies the version it resolved for this query run. Reading the
config here would
+ * capture whatever value happened to be set when this log was constructed
-- which is during
+ * [[StreamExecution]]'s own initialization, before per-query configuration
is applied -- and
Review Comment:
will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
