dongjoon-hyun opened a new pull request, #486:
URL: https://github.com/apache/spark-connect-swift/pull/486

   ### What changes were proposed in this pull request?
   
   This PR replaces the dead `// TODO: post` block in 
`DataStreamWriter.start()` with a comment
   documenting that `WriteStreamOperationStartResult.queryStartedEventJson` is 
intentionally
   ignored because this client does not support `StreamingQueryListener` yet.
   
   ### Why are the changes needed?
   
   The previous code checked `result.hasQueryStartedEventJson` and did nothing, 
leaving a
   misleading `TODO` that suggested an unfinished code path. Reference clients 
(PySpark and
   Scala Connect) parse this JSON into a `QueryStartedEvent` and post it to 
their
   `StreamingQueryListener` bus, which is a no-op when no listener is 
registered. Since this
   client has no listener subsystem, dropping the event is semantically 
equivalent; the comment
   now records that decision and marks the posting point for future listener 
support.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Pass the CIs. This is a comment-only change with no behavior difference.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Fable 5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to