anew commented on code in PR #57644:
URL: https://github.com/apache/spark/pull/57644#discussion_r3770192916
##########
sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/Flow.scala:
##########
@@ -494,3 +494,22 @@ class AutoCdcMergeFlow(
}
}
+
+object AutoCdcMergeFlow {
Review Comment:
Minor placement thought (non-blocking): `AutoCdcReservedNames` already owns
the reserved `prefix` and `cdcMetadataColName`, and its docs are the canonical
statement of what AUTO CDC reserves. Since `isReservedFieldName` /
`reservedFields` / `stripReservedFields` are all just "is this name/schema
reserved?" predicates keyed off that same prefix, they'd read more naturally in
`AutoCdcReservedNames` (co-located with the definition of what "reserved"
means) than in the `AutoCdcMergeFlow` companion. That keeps the single source
of truth for reserved-column semantics in one object, and avoids growing an
`AutoCdcMergeFlow` companion purely for schema predicates. Feel free to keep it
here if you'd rather have it next to the flow that actually produces the
columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
