nchammas commented on code in PR #58038: URL: https://github.com/apache/spark/pull/58038#discussion_r3796876997
########## docs/sql-ref-null-semantics.md: ########## @@ -385,6 +394,8 @@ two `NULL` values are not equal. However, for the purpose of grouping and distin values with `NULL data`are grouped together into the same bucket. This behaviour is conformant with SQL standard and with other enterprise database management systems. +`COUNT(DISTINCT expr)` still follows the aggregate rule above and does not count null. Review Comment: Nit: It's not clear which aggregate rule this line is referring to. Is it this? https://github.com/apache/spark/blob/653ddad6233a8dc7b574f4f030ff9693c2502908/docs/sql-ref-null-semantics.md#L245-L246 I would just restate the rule since linking directly to it is not straightforward. Or, we could just remove this line since the previous section already covers `COUNT` and `COUNT DISTINCT`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
