Vamsi-klu commented on code in PR #58038: URL: https://github.com/apache/spark/pull/58038#discussion_r3797386312
########## docs/sql-ref-null-semantics.md: ########## @@ -385,6 +394,8 @@ two `NULL` values are not equal. However, for the purpose of grouping and distin values with `NULL data`are grouped together into the same bucket. This behaviour is conformant with SQL standard and with other enterprise database management systems. +`COUNT(DISTINCT expr)` still follows the aggregate rule above and does not count null. Review Comment: Agreed, “the aggregate rule above” was too vague. I restated it here so it is clear that COUNT(DISTINCT) ignores NULL values, instead of pointing back to the earlier section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
