nchammas commented on PR #58032: URL: https://github.com/apache/spark/pull/58032#issuecomment-5317671875
I didn't even consider that the performance might be different. I ran some local microbenchmarks and confirmed that `exist_ok` is slower. (For the record, the absolute run time is still very small: ~1.7 µs vs. ~5.5 µs.) Since this is meant to be a `[MINOR]` change, and researching the potential performance impact is more than I'm looking to do here, I've reverted the changes everywhere except to `setup.py`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
