HeartSaVioR commented on PR #58064: URL: https://github.com/apache/spark/pull/58064#issuecomment-5352588875
Maybe beyond the scope of the PR, but KafkaDelegationTokenProvider.obtainDelegationTokens seems to log the warning message and swallow when KafkaTokenUtil.obtainToken raises exception. The code is there as it is so maybe it's fine, but I wonder whether fail-fast is somehow better; I'm away from delegation token for 5+ years so just a grain of salt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
