pan3793 commented on PR #58064: URL: https://github.com/apache/spark/pull/58064#issuecomment-5352676709
@HeartSaVioR, thanks for the review and for raising your thoughts. > KafkaDelegationTokenProvider.obtainDelegationTokens seems to log the warning message and swallow when KafkaTokenUtil.obtainToken raises exception. ... I wonder whether fail-fast is somehow better I think it's by design, the `obtainDelegationTokens` API signature says: > ``` > @return If the returned tokens are renewable and can be renewed, return the time of the next > renewal, otherwise None should be returned.` > ``` And I checked all existing built-in `HadoopDelegationTokenProvider`s (Hive, HDFS, HBase), all of them log the exception and return None instead of failing fast when an error occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
