pan3793 commented on PR #58314: URL: https://github.com/apache/spark/pull/58314#issuecomment-5450072448
Thanks for the second pass! **1.** Correct -- noted in the PR description: the anonymous cached name is now rendered at materialization time, so for adaptive plans it is derived from the final AQE plan; the user-facing section is adjusted accordingly. **2.** Added to the config doc: "The name is resolved when the cache is first materialized." **3.** Switched to `cachedPlan.id`, with a self-describing name format: `CachedRDD (plan_id=42)`. This drops the companion object, the `AtomicLong`, and the id-consumption caveat; the config is renamed to `spark.sql.dataframeCache.planIdName.enabled`. **4.** Added `SPARK-59024: anonymous cached name is not rendered before materialization` -- a `ToStringCountingPlan` leaf asserts `toString` is never called at cache construction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
