pan3793 commented on PR #58314: URL: https://github.com/apache/spark/pull/58314#issuecomment-5457427924
Thanks for the third pass! **1.** Keeping the explicit `CachedRDD (plan_id=N)` label -- the config is internal, and the id remains a useful debugging handle even if `explain` does not show a cross-reference for every plan. **2.** Reworded: "Caches of the same physical plan instance share the plan id." **3.** Reworded the comment: "Resolved on first access (cache materialization for anonymous caches)." **4.** Added the reverse assertion: forcing the name renders the tree string exactly once. Also rebased onto master and resolved the conflict with the SPARK-59009 test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
