ahshahid commented on code in PR #58003:
URL: https://github.com/apache/spark/pull/58003#discussion_r3879318818


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -942,7 +943,8 @@ case class AdaptiveSparkPlanExec(
       optimizeQueryStage(plan, isFinalStage = true),
       postStageCreationRules(supportsColumnar),
       "AQE Post Stage Creation")
-    val resultStage = ResultQueryStageExec(currentStageId, optimizedRootPlan, 
resultHandler)
+    val resultStage = ResultQueryStageExec(currentStageId, optimizedRootPlan, 
plan.canonicalized,

Review Comment:
   ResultQueryStageExec extends QueryStageExec. So if the abstract fields of 
_canonicalize  is moved to QueryStageExec,  what do you have in mind to 
override it in ResultQueryStageExec?
   
   override def doCanonicalize(): SparkPlan = {
       ResultQueryStageExec(-1, _canonicalized, _canonicalized, resultHandler)
     }
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to