ahshahid commented on code in PR #58003:
URL: https://github.com/apache/spark/pull/58003#discussion_r3881992063


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -942,7 +943,8 @@ case class AdaptiveSparkPlanExec(
       optimizeQueryStage(plan, isFinalStage = true),
       postStageCreationRules(supportsColumnar),
       "AQE Post Stage Creation")
-    val resultStage = ResultQueryStageExec(currentStageId, optimizedRootPlan, 
resultHandler)
+    val resultStage = ResultQueryStageExec(currentStageId, optimizedRootPlan, 
plan.canonicalized,

Review Comment:
   @ulysses-you ..I suppose the overriding  doCanonicalize in 
ResultQueryStageExec as  in the PR , should work as right canonicalized code. 
From what I understand of what you implied of  "plan + resultHandler", looks 
like ResultQueryStageExec , also had an issue, which should be addressed by 
this PR...
   Pls lmk your thoughts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to