zhengchenyu commented on PR #57350: URL: https://github.com/apache/spark/pull/57350#issuecomment-5490563661
@sunchao I have added restrictions on local mode. For now, two reviews remain unresolved: (1) [P1] Withdraw the UI Service selector before stopping Jetty: I tried modifying to delete the UI service before `_ui.foreach(_.stop())`, but this makes the code very messy. I don't want to mess up the code for such a low-probability and insignificant issue. Therefore, this remains unfixed. (2) [P2] Clean up external UI Services when the driver exits before SparkContext: I think this issue wasn't introduced by this PR; the driver service also has this problem. We should create the service after the driver starts to solve the issue. However, I don't think this should be addressed in this PR. Moreover, the probability of this problem is extremely low. I don't think it's necessary to fix these two issues for now. What do you think? Should we continue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
