pan3793 commented on PR #58312: URL: https://github.com/apache/spark/pull/58312#issuecomment-5546155631
Thanks for the review and the careful walk-through. 1. Added a comment on the disk measurement in `release()`, with the reason you gave. 2. Done: `commit()` now drops a leftover listing entry and its accounting when the previous store directory is gone, the same shape as `makeRoom()`, so all three paths agree that a listed store is a counted store. Added `commit deducts a store deleted out of band`. 3. Done: a failed `renameTo` now raises an `IOException`; both call sites roll the lease back on it. 4. Added a note on the log key change to the description. 5. Reworded the `release()` scaladoc. 6. Will carry the trade-off paragraph into the backport PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
