pan3793 commented on PR #58635: URL: https://github.com/apache/spark/pull/58635#issuecomment-5603220003
@cloud-fan @ulysses-you, thanks for taking a look, I'd like to discuss one thing before making subsequent changes. Both of you point out that the `isRepeatableRuntimeFilterSource` justification is inadequate, but it looks like the same things are spread out across the codebase, for example, the CTE justifies determinism only by `QueryPlan.deterministic`, do you think it's fine to just follow that here too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
