cloud-fan commented on PR #58635:
URL: https://github.com/apache/spark/pull/58635#issuecomment-5643433486
I agree with moving beyond QueryPlan.deterministic. The current analysis is
much closer, but it still accepts two sources that can change keys across
evaluations: multiplicity-sensitive aggregates above a nondeterministic outer
generator, and opaque uncheckpointed LogicalRDD leaves. Those should be
rejected or tracked before the hint is considered safe.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:5603220003","thread_id":"conversation:5603220003","verdict_sha256":"7420fc2de59b7ada011c053eea2a54ada04cf904d9431a35824b4dcb466fbd51"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
