srielau commented on PR #58530: URL: https://github.com/apache/spark/pull/58530#issuecomment-5642826752
After reviewing the repeated recovery fixes as a whole, I simplified the PR in 87610602065. It no longer adds a parse_sql-specific batch grammar or malformed-BEGIN recovery policy. parse_sql now reuses the existing positioned SqlStatementSplitter path and stock-parses each emitted segment, as in the original design. Valid compound scripts, variable-reference validation, extension fallback, and malformed-input behavior are therefore inherited from the shared splitter. The UTF-16 offset mapping, SQL-whitespace trimming, source-span contract, and closed-comment clarification remain. Focused splitter/result/expression/golden tests and both SQL scalastyle targets pass. Any stronger malformed-compound recovery should be addressed separately in the shared splitter so all callers have one contract. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
