srielau commented on PR #58530: URL: https://github.com/apache/spark/pull/58530#issuecomment-5654199121
On the advisory question in the latest review: yes, inheriting the shared splitter's documented O(k^2) growing-prefix cost for valid `BEGIN ... END` scripts is an accepted limitation for `parse_sql`. This PR keeps one splitter contract with `SparkSqlParser.splitStatements`. If that cost shows up in practice, we will fix `SqlStatementSplitter` separately rather than adding a `parse_sql`-only boundary path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
