urosstan-db opened a new pull request, #58762:
URL: https://github.com/apache/spark/pull/58762
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'common/utils/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Report invalid JDBC date and timestamp partition bounds using
`SparkIllegalArgumentException` with condition
`INVALID_JDBC_PARTITION_BOUND` and
SQLSTATE `22023`. The message identifies whether `lowerBound` or
`upperBound` is
invalid, the supplied value, and the expected data type.
Draft pending an Apache Spark JIRA.
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
An invalid JDBC partition bound currently throws a plain
`IllegalArgumentException`
without an error condition or SQLSTATE. For example, an unexpanded template
value
such as `{bound}` fails with `Cannot parse the bound value {bound} as
timestamp`,
which does not identify which JDBC option to correct.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
Yes. Invalid `DATE`, `TIMESTAMP`, and `TIMESTAMP_NTZ` partition bounds now
produce
a structured error, for example:
```text
[INVALID_JDBC_PARTITION_BOUND] Cannot parse the value "{bound}" for JDBC
option "upperBound" as "TIMESTAMP". SQLSTATE: 22023
```
The exception remains an `IllegalArgumentException` subtype. Valid bound
parsing
and the generated partition predicates are unchanged.
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Added `JDBCRelationSuite` with cases for invalid lower and upper bounds
across all
three temporal types, including placeholder values, empty strings, and
invalid
calendar dates. Positive cases check the generated partition predicates.
Updated the existing `JDBCSuite` timezone-bound regression test to check the
structured error.
Passed locally with Java 17: all 21 `JDBCRelationSuite` cases, all 38
`SparkThrowableSuite` cases, and all 3 selected `JDBCSuite` partitioning
cases.
```text
build/sbt "sql/testOnly
org.apache.spark.sql.execution.datasources.jdbc.JDBCRelationSuite" \
"core/testOnly org.apache.spark.SparkThrowableSuite" \
"sql/testOnly org.apache.spark.sql.jdbc.JDBCSuite -- -z columnPartition"
```
Scala style checks passed with no errors or warnings:
```text
build/sbt "catalyst/scalastyle" "sql/scalastyle" "sql/Test/scalastyle"
```
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex CLI 0.153.4
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
