urosstan-db commented on code in PR #58762:
URL: https://github.com/apache/spark/pull/58762#discussion_r3997096641
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala:
##########
@@ -198,11 +200,11 @@ private[sql] object JDBCRelation extends Logging {
private def toInternalBoundValue(
value: String,
columnType: DataType,
- timeZoneId: String): Long = {
+ timeZoneId: String,
+ option: String): Long = {
Review Comment:
I would rather name it optionName, as well change name in
invalidJdbcPartitionBoundError
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala:
##########
@@ -198,11 +200,11 @@ private[sql] object JDBCRelation extends Logging {
private def toInternalBoundValue(
value: String,
columnType: DataType,
- timeZoneId: String): Long = {
+ timeZoneId: String,
+ option: String): Long = {
Review Comment:
I would rather name it optionName, also change name in
invalidJdbcPartitionBoundError
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
