dongjoon-hyun opened a new pull request, #825: URL: https://github.com/apache/spark-kubernetes-operator/pull/825
### What changes were proposed in this pull request? This PR aims to use the `enabled` key convention in the Helm chart `values.yaml` while still honoring the legacy `enable` keys. - `operatorDeployment.networkPolicy.enable` → `operatorDeployment.networkPolicy.enabled` - `operatorConfiguration.dynamicConfig.enable` → `operatorConfiguration.dynamicConfig.enabled` Two helpers in `_helpers.tpl` resolve each toggle to `true` when either the new or the legacy key is `true`, and all templates use them. The legacy keys stay valid in `values.schema.json`, marked as deprecated, and will be removed in chart `2.0.0`. ### Why are the changes needed? `<feature>.enabled` is the common Helm convention, and the operator's runtime property is already `spark.kubernetes.operator.dynamicConfig.enabled`. Resolving with `or` keeps existing `enable: true` users working because the chart default `enabled: false` is always merged and cannot be distinguished from a user-supplied value. ### Does this PR introduce _any_ user-facing change? Yes, compared to [v1.0.0 (2026-07-23)](https://github.com/apache/spark-kubernetes-operator/releases/tag/1.0.0). New users should use `enabled`. Existing values files with `enable` keep working without modification. ### How was this patch tested? - `helm lint --strict` passes. - Rendered with `helm template` for default, `enabled=true`, legacy `enable=true`, and legacy `enable=false` and confirmed the expected resources and properties. - Added a CI step in the `lint` job that renders the chart with the legacy `enable` keys and asserts they are still honored. - Existing Helm and E2E tests cover the new `enabled` keys. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
