dongjoon-hyun commented on PR #825: URL: https://github.com/apache/spark-kubernetes-operator/pull/825#issuecomment-5682427592
Thank you for the second pass, @peter-toth. Addressed in 4541e30. - **3.** Filed SPARK-59537 for `operatorRbac.configManagement.create`. - **6.** Added a `Validate helm values resolve to disabled` step next to the ON-direction one. It asserts the NetworkPolicy is absent on the default values and on `networkPolicy.enable=false`, and that `dynamicConfig.enabled=true` is not emitted on `dynamicConfig.enable=false`, using `if ... then exit 1` as you suggested. I confirmed it fails on the stuck-on helper mutation and passes on this head. - **7.** Agreed on the value of an install-time signal. I'd like to keep this PR to the rename and handle the `NOTES.txt` warning in a follow-up PR, together with SPARK-59533. - **8.** Moved the deprecation paragraph to the end of the NetworkPolicy section, after the CNI note. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
