srielau commented on PR #58317: URL: https://github.com/apache/spark/pull/58317#issuecomment-5800432553
Thanks for the `b8d27c0e` delta review. I agree this is a CacheManager lifecycle contract, not remaining SPARK-58814 format/ORC work. I reverted that commit (`66461ef7956`) so this PR stays on format round-trips plus the scan-mode regressions already required here. The remaining items are tracked in [SPARK-59751](https://issues.apache.org/jira/browse/SPARK-59751): - One CacheManager descriptor (resolved origin, plan, bound mode, storage level) for V1/V2/Hive mutation, refresh, and rename - Isolated restoration context instead of caller `withSQLConf` - Resolved-table identity for direct V2 caches (not CACHE TABLE display names) - Explicit Legacy policy preserved with PreserveNative and SparkStandard - Bound CHAR/VARCHAR fixtures in the V1 insert and save regressions - The three nits (predicate short-circuit, bind inside the padding traversal, V2 descriptor Scaladoc) Ordinary cache substitution stays mode-sensitive; mutation continues to ignore only scan mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
