vranes commented on code in PR #59001: URL: https://github.com/apache/spark/pull/59001#discussion_r4093885728
########## docs/sql-ref-ansi-compliance.md: ########## @@ -431,7 +431,7 @@ Below is a list of all the keywords in Spark SQL. |AS|reserved|non-reserved|reserved| |ASC|non-reserved|non-reserved|non-reserved| |ASENSITIVE|non-reserved|non-reserved|non-reserved| -|ASOF|non-reserved|non-reserved|non-reserved| +|ASOF|reserved|strict-non-reserved|non-reserved| Review Comment: ANSI mode should probably match SQL-2016, like in ANTI case ########## sql/core/src/test/resources/sql-tests/inputs/join-asof-grammar.sql: ########## @@ -128,6 +128,9 @@ SELECT * FROM trades t LEFT SEMI ASOF JOIN quotes q -- FVT-ASOF-1-017: missing MATCH_CONDITION SELECT * FROM trades t ASOF JOIN quotes q ON t.symbol = q.symbol; +-- FVT-ASOF-1-020: missing MATCH_CONDITION with no left alias is rejected, not a plain join +SELECT * FROM trades ASOF JOIN quotes USING (symbol); Review Comment: 1. what about `AS ASOF` ? 2. what about `AS ASOF` with `MATCH_CONDITION`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
