LukaZdravic commented on code in PR #59001: URL: https://github.com/apache/spark/pull/59001#discussion_r4094760765
########## docs/sql-ref-ansi-compliance.md: ########## @@ -431,7 +431,7 @@ Below is a list of all the keywords in Spark SQL. |AS|reserved|non-reserved|reserved| |ASC|non-reserved|non-reserved|non-reserved| |ASENSITIVE|non-reserved|non-reserved|non-reserved| -|ASOF|non-reserved|non-reserved|non-reserved| +|ASOF|reserved|strict-non-reserved|non-reserved| Review Comment: ASOF cannot be non-reserved, because it can then be read as a table alias, same as the `AS` we talked about above. However ANTI that you mention has the same problem `SELECT * FROM t ANTI JOIN u USING (k)` this return the inner join rows not the anti join rows. Definitely worth a follow up, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
