naveenp2708 opened a new pull request, #59129: URL: https://github.com/apache/spark/pull/59129
What changes were proposed in this pull request? A follow-up test for SPARK-59688. It adds a LEFT OUTER join to KeyGroupedPartitioningSuite, over the same identity(id) against flip_low_bit(id) setup the fix already covers for an inner join. Test only, no production change. Why are the changes needed? The three tests in SPARK-59688 all use an inner join, where the wrong result is missing rows (0 of 2). An outer join hits the same coinciding-keys bug with a different symptom: it keeps the left rows and null-extends them, so it returns (0, 'a', null) instead of (0, 'a', 'x'). That reads like a legitimate no-match rather than an obviously missing row, so it is worth pinning on its own. The test fails on a revert of the fix (returns the null-extended rows) and passes with it. Does this PR introduce any user-facing change? No. Test only. How was this patch tested? The new test. It fails on a revert of the partitioning.scala fix and passes with it. KeyGroupedPartitioningSuite runs green (196 tests). Was this patch authored or co-authored using generative AI tooling? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
