naveenp2708 commented on PR #59129: URL: https://github.com/apache/spark/pull/59129#issuecomment-5904838895
@szehon-ho @uros-b Good call on parameterizing. The existing test now runs over JOIN and LEFT OUTER JOIN so they share the setup and assertions, and I dropped the separate one. Both expect the same rows here so it's a clean loop. Also fixed the description, the three original tests are an end-to-end inner join, shuffle-spec compatibility, and cogroup planning. CI is green now and the comment is trimmed. Thanks both for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
