cloud-fan commented on PR #58656:
URL: https://github.com/apache/spark/pull/58656#issuecomment-5884995716
I would keep full self-join preparation and the pre-existing
dedupSubqueryOnSelfJoin asymmetry as a follow-up: current supported SQL inputs
are analyzer-deduplicated, and the remaining conflict failure predates this PR.
The effective-reference invariant is appropriate because it is derived from the
compared values and hoisted conditions the rewrite actually consumes; I do not
see a supported reused-ExprId counterexample on this head. The two error names
are reasonable. Please file the released outer/projection three-valued-IN
behavior as a separate JIRA. Also update the PR description's both-plan example
to name NESTED_SUBQUERY_REFERENCING_OUTER_AND_INNER_QUERY.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:5853675261","thread_id":"conversation:5853675261","verdict_sha256":"2cd9f1ced1b3473e0a464ba4a11f3bf67e36b6ecf38ad62dfcd78c05b261f024"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
