pratham76 commented on PR #58656: URL: https://github.com/apache/spark/pull/58656#issuecomment-5891452714
> I would keep full self-join preparation and the pre-existing dedupSubqueryOnSelfJoin asymmetry as a follow-up: current supported SQL inputs are analyzer-deduplicated, and the remaining conflict failure predates this PR. The effective-reference invariant is appropriate because it is derived from the compared values and hoisted conditions the rewrite actually consumes; I do not see a supported reused-ExprId counterexample on this head. The two error names are reasonable. Please file the released outer/projection three-valued-IN behavior as a separate JIRA. Also update the PR description's both-plan example to name NESTED_SUBQUERY_REFERENCING_OUTER_AND_INNER_QUERY. Thanks for the comments @cloud-fan, I have addressed all of them, and have update PR description as well - PTAL again. Also have opened a new JIRA [SPARK-59862](https://issues.apache.org/jira/browse/SPARK-59862) to track `three-valued-IN behavior`, I will start working on this shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
