LukaZdravic commented on code in PR #59016: URL: https://github.com/apache/spark/pull/59016#discussion_r4131894513
########## sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeAsOfJoinExec.scala: ########## @@ -424,10 +405,38 @@ private[joins] class SortMergeAsOfJoinScanner( } /** - * Forward scan for Forward/Nearest joins: distance-based termination. - * Stop when distance starts increasing past the minimum found so far. + * Forward joins: returns the first row that passes both conditions. It picks by buffer + * order, not by distance: the distance can rank STRUCT and ARRAY values wrongly, for Review Comment: Thanks, will fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
