LukaZdravic commented on code in PR #59016:
URL: https://github.com/apache/spark/pull/59016#discussion_r4133285332
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -2772,8 +2772,7 @@ object AsOfJoin {
*/
private[catalyst] object MatchConditionTypes {
- def isValidOperandType(dataType: DataType): Boolean =
- RowOrdering.isOrderable(dataType) && !containsEmptyStructType(dataType)
+ def isValidOperandType(dataType: DataType): Boolean =
RowOrdering.isOrderable(dataType)
Review Comment:
https://github.com/apache/spark/pull/59134, one thing to mention, it doesn't
contain yet the test for forward matching because I am waiting for
https://github.com/apache/spark/pull/59102 to merge which fixes the not needed
distance calculation for forward join. It says the same in the description, I
just tought it's worth mentioning here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
