aokolnychyi commented on code in PR #59119: URL: https://github.com/apache/spark/pull/59119#discussion_r4136760808
########## sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ChangelogTable.scala: ########## @@ -42,6 +42,29 @@ case class ChangelogTable( // and correct types. ChangelogTable.validateSchema(changelog) + // Capture the metadata used to build the analyzer's CDC post-processing operators. + private val carryovers = changelog.containsCarryoverRows() Review Comment: Why not follow the name of the methods for variables? I love shorter var names but it feels like we are loosing some important context here. Also, can we group these variables a bit? ``` private val containsCarryoverRows = changelog.containsCarryoverRows private val containsIntermediateChanges = changelog.containsIntermediateChanges private val representsUpdateAsDeleteAndInsert = changelog.representsUpdateAsDeleteAndInsert private[sql] val requiresCarryoverRemoval = private[sql] val requiresUpdateDetection = private[sql] val requiresNetChangeCollapse = private val rowId = ... private val rowVersion = ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
