aokolnychyi commented on code in PR #59119: URL: https://github.com/apache/spark/pull/59119#discussion_r4136847164
########## sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ChangelogTable.scala: ########## @@ -42,6 +42,29 @@ case class ChangelogTable( // and correct types. ChangelogTable.validateSchema(changelog) + // Capture the metadata used to build the analyzer's CDC post-processing operators. + private val carryovers = changelog.containsCarryoverRows() + private val intermediateChanges = changelog.containsIntermediateChanges() + private val updatesAsDeleteAndInsert = changelog.representsUpdateAsDeleteAndInsert() + private[sql] val requiresCarryOverRemoval = + changelogContext.deduplicationMode() != ChangelogContext.DeduplicationMode.NONE && carryovers + private[sql] val requiresUpdateDetection = Review Comment: Also, do we really need `PostProcessingRequirements`? Why not just pass around ChangelogTable everywhere? The container seems useless at this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
