nchammas commented on PR #59182: URL: https://github.com/apache/spark/pull/59182#issuecomment-5950412138
> The reasoning is sound, but the two mechanisms don't actually free the same space They don't free the same space, but they do free space on the same disk, which is what I was getting at. I've adjusted the PR description. > Could you confirm the macOS runners have enough headroom for the precompiled artifact (every module target/) plus two venvs and two PySpark installs? Confirmed and updated the PR description accordingly. I will revert the temporary commit after the macOS build completes. > On a persistent or self-hosted workspace, or a re-run after a packaging run with a different version, it can now fail or ship stray files. The git cleanup was not introduced for any of these reasons. It was just to free up space on GitHub runners. I've updated the PR description accordingly. > Could you link a run where the pip packaging step actually executed with this change (ideally on both Linux and macOS)? Done in the updated PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
