srielau commented on code in PR #59188:
URL: https://github.com/apache/spark/pull/59188#discussion_r4174121725
##########
sql/core/src/test/scala/org/apache/spark/sql/CharVarcharTestSuite.scala:
##########
@@ -2607,37 +2605,12 @@ class BasicCharVarcharTestSuite extends
SharedSparkSession {
checkAnswer(
sql("""SELECT length(CAST('{"a":1}' AS CHAR(20)))"""),
Row(20))
- checkAnswer(
- sql("""SELECT schema_of_json(CAST('{"a":1}' AS CHAR(20)))"""),
Review Comment:
Restored the CHAR `schema_of_json` / `schema_of_xml` checks and the `COLLATE
SR_AI` trio. The collated `schema_of_csv` case now expects `STRUCT<_c0: INT,
_c1: STRING, _c2: STRING>` because the pad is no longer rtrimmed. Also put back
`from_xml(CAST(... AS CHAR(30)), 'a INT')`, which still parses since XML
ignores trailing whitespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
