HyukjinKwon commented on code in PR #59188:
URL: https://github.com/apache/spark/pull/59188#discussion_r4176028573
##########
sql/core/src/test/scala/org/apache/spark/sql/CharVarcharTestSuite.scala:
##########
@@ -2607,37 +2605,12 @@ class BasicCharVarcharTestSuite extends
SharedSparkSession {
checkAnswer(
sql("""SELECT length(CAST('{"a":1}' AS CHAR(20)))"""),
Row(20))
- checkAnswer(
- sql("""SELECT schema_of_json(CAST('{"a":1}' AS CHAR(20)))"""),
Review Comment:
Confirmed -- the restored schema_of_json / schema_of_xml CHAR checks and the
COLLATE SR_AI trio (with the updated schema_of_csv result) plus the from_xml
CHAR(30) case are present in CharVarcharTestSuite and cover the
SchemaOfJson/SchemaOfXml CHAR acceptance. This resolves the thread. Thanks.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"inline:4157794530","thread_id":"inline:4157794530","verdict_sha256":"fe00ecae72a7b9daabf1e92fa88e0abeb3537a72c995ee09b273ed55b53f800c"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
