peter-toth commented on PR #58895: URL: https://github.com/apache/spark/pull/58895#issuecomment-6011559138
@sunchao thank you for the review, and for the note on Comet. - The cancelled CI shards could not get a hosted runner. The new push runs them again, `ParquetStorageFilterSuite` included. - P3: done. `storageFiltersFor` takes the filters as they are and builds the `ExpressionSet` only after its two guards, still before the `filter`. A new planner test pins the deduplication, which nothing covered before. - The benchmark now checks, untimed, that both arms return the same rows, by count and by a fingerprint over every column. - The pre-sizing is gone, as dongjoon also suggested in this round. - The coverage boundaries in your table make sense as follow-ups. I'd keep them out of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
