Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6804#discussion_r32690391
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -69,8 +73,8 @@ public UTF8String set(final String str) {
/**
* Updates the UTF8String with byte[], which should be encoded in UTF-8.
*/
- public UTF8String set(final byte[] bytes) {
- this.bytes = bytes;
+ protected UTF8String set(final byte[] bytes) {
+ this.bytes = (bytes != null) ? bytes : new byte[0];
--- End diff --
If we don't want to accept `null`, I'd prefer to throw an exception. It's
much easier to find a bug later, if the `set` throws an exception instead of
any other method that runs into a null pointer exception. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
