Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6804#discussion_r32690842
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -178,6 +189,7 @@ public UTF8String clone() {
@Override
public int compareTo(final UTF8String other) {
+ if (other == null) return 1;
--- End diff --
The expression `RowOrdering` actually did the null testing already before
call the `compareTo`, see
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/rows.scala#L218
So, we are sure the argument passed in will be non-null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
