viirya commented on code in PR #941: URL: https://github.com/apache/spark-kubernetes-operator/pull/941#discussion_r4200783544
########## docs/spark_custom_resources.md: ########## @@ -540,7 +540,7 @@ running `SparkCluster` is stopped instead, as described below. `suspend: true`, the initial `Submitted` status is not persisted to the API server, so `kubectl get` shows an empty `Current State` and no state transition events are published until initialization resumes. Instead, the `SuspendHeld` [event](configuration.md#kubernetes-events) is -published when enabled. Since the status is not there to fall back on, it is republished every 30 +published. Since the status is not there to fall back on, it is republished every 30 Review Comment: Nit: could we say “published by default” here and in the corresponding Kueue passages? Events can still be disabled globally or filtered by reason, so removing “when enabled” entirely makes these statements sound unconditional. “By default” would describe the new behavior while preserving that distinction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
