dongjoon-hyun commented on PR #941: URL: https://github.com/apache/spark-kubernetes-operator/pull/941#issuecomment-6026274611
Thank you for the review and approval, @viirya. For the follow-up suggestion, I added two sink-level tests to `ConfigurableEventRecorderDefaultSinkTest`. `makesNoRequestWhileDisabled` verifies that disabling events makes no Event API request, and `dropsAForbiddenWriteWithoutThrowing` verifies that a forbidden write is dropped without throwing out of the reconciliation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
