dongjoon-hyun commented on code in PR #946:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/946#discussion_r4203629023
##########
spark-operator-api/src/main/java/org/apache/spark/k8s/operator/status/ApplicationStatus.java:
##########
@@ -205,10 +205,57 @@ public ApplicationStatus terminateOrRestart(
currentAttemptSummary);
}
- ApplicationAttemptSummary nextAttemptSummary = new
ApplicationAttemptSummary(nextAttemptInfo);
- ApplicationState state =
- new ApplicationState(ApplicationStateSummary.ScheduledToRestart,
stateMessageOverride);
+ return startNextAttempt(
+ new ApplicationState(ApplicationStateSummary.ScheduledToRestart,
stateMessageOverride),
+ nextAttemptInfo,
+ trimStateTransitionHistory);
+ }
+
+ /**
+ * Starts a new attempt of a suspended application which is resumed. Like a
restart, the new
Review Comment:
Thank you, @viirya. I added a paragraph saying that it only creates the
status of the new attempt, and that the resources of the suspended attempt are
expected to be released already, like `terminateOrRestart`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
