sweb commented on code in PR #58010:
URL: https://github.com/apache/spark/pull/58010#discussion_r4211287156
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala:
##########
@@ -536,7 +536,8 @@ class ExecutorPodsAllocator(
applicationId,
driverPod,
resourceProfileId,
- Option(secMgr.getSecretKey()))
+ Option(secMgr.getSecretKey()),
+ secMgr.getEnvironmentForSslRpcPasswords)
Review Comment:
The allocators now use a new
`SecurityManager.getEnvironmentForSslRpcPasswordsFromSparkConf` - addressed in
https://github.com/apache/spark/pull/58010/changes/02255a829394a1d11edd7116bf039c1e6445ba8c
and
https://github.com/apache/spark/pull/58010/changes/118c151904cf9278b69cc8b7e4c037ea1cf6ba4d
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala:
##########
@@ -216,7 +216,8 @@ class KubernetesExecutorConf(
val executorId: String,
val driverPod: Option[Pod],
val resourceProfileId: Int = DEFAULT_RESOURCE_PROFILE_ID,
- customAuthSecret: Option[String] = None)
+ customAuthSecret: Option[String] = None,
+ val sslRpcPasswordEnvs: Map[String, String] = Map.empty)
Review Comment:
Done - addressed in
https://github.com/apache/spark/pull/58010/changes/118c151904cf9278b69cc8b7e4c037ea1cf6ba4d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
