sweb commented on code in PR #58010:
URL: https://github.com/apache/spark/pull/58010#discussion_r4211284973
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala:
##########
@@ -142,6 +142,21 @@ private[spark] class BasicExecutorFeatureStep(
case _ => Nil
}.getOrElse(Nil)
+ // SparkConf.isExecutorStartupConf withholds the spark.ssl.* passwords
from the
+ // executor conf. The pod allocator resolves them from the driver
SecurityManager
+ // and passes them in through the environment, as the standalone worker
does in
+ // CommandUtils. A name the user already binds, via
+ // spark.kubernetes.executor.secretKeyRef, spark.executorEnv or the pod
template,
+ // is skipped and the user's value wins: buildEnvVars does not
deduplicate and
+ // Kubernetes resolves a repeated name last-wins.
+ val userBoundEnvNames = kubernetesConf.secretEnvNamesToKeyRefs.keySet ++
+ kubernetesConf.environment.keySet ++
+ Option(pod.container).flatMap(c => Option(c.getEnv))
Review Comment:
I completely missed this - thank you for pointing it out. This is addressed
in
https://github.com/apache/spark/pull/58010/changes/46a14409b9bee5b349b9b937990cae01fd24680a
and
https://github.com/apache/spark/pull/58010/changes/59004616f6da7536a5b7ccf89e9726d5a6d8acd4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
