nchammas commented on PR #58860: URL: https://github.com/apache/spark/pull/58860#issuecomment-6046412962
> it seems like you wrote a new function just to test that all the pyspark modules depend on the base module? Yes. We have so much code for our build that we honestly need tests to ensure the build itself is working as expected. We don't have the setup currently for separate test files, and I think in the future we should do that so we don't continue to (IMO) overuse doctests as we currently are. > Is the file even executed (as a doctest) in CI? Yep. Right here: https://github.com/apache/spark/blob/7b3bb8fb45544f2d983e7519683d61baa737a98f/dev/run-tests.py#L673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
